Skip to content

chore(nhi): rename is_secret_vaulted to is_vaulted #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

amascia-gg
Copy link
Contributor

No description provided.

@amascia-gg amascia-gg requested a review from a team as a code owner May 7, 2025 12:15
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (f93b8e2) to head (09a2436).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files           5        5           
  Lines        1208     1208           
=======================================
  Hits         1157     1157           
  Misses         51       51           
Flag Coverage Δ
unittests 95.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amascia-gg amascia-gg force-pushed the amascia/-/rename-serializer-field branch from d1dfaa9 to e679482 Compare May 7, 2025 12:20
Copy link
Contributor

@sevbch sevbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, approving beforehand

@amascia-gg amascia-gg force-pushed the amascia/-/rename-serializer-field branch from e679482 to 09a2436 Compare May 7, 2025 12:25
@amascia-gg amascia-gg enabled auto-merge May 7, 2025 12:25
@amascia-gg amascia-gg merged commit 2f6da32 into master May 7, 2025
19 checks passed
@amascia-gg amascia-gg deleted the amascia/-/rename-serializer-field branch May 7, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants