fix: Add missing scopes to TokenScope enum #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 95.75% 95.77% +0.01%
==========================================
Files 5 5
Lines 1202 1206 +4
==========================================
+ Hits 1151 1155 +4
Misses 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sevbch
reviewed
Apr 25, 2025
salome-voltz
force-pushed
the
salomevoltz/add-missing-scopes
branch
from
6c68494 to
de5cd62
Compare
sevbch
approved these changes
Apr 25, 2025
agateau-gg
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in ggshield.
When trying to scan somthing with flag
--with-incident-details, ggshield performs a call to/api_tokens/{token}. The response is deserialized using an enum for scopes.The enum was missing some recently added scope. Thus,
ggshield secret scan path FILE --with-incident-detailswas crashing when called with a token having the new scopes :