Remove minimum requirement for C# version 7 #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes means that C# v7 is no longer a minimum requirement
Add explicity variable declaration for the out variable. This changes means that C# v7 is no longer a minimum requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding explicit variable declarations for an out variable, instead of declaring them in the method call means that C# version 7 is not a minimum requirement, and different version of msbuild can be used. So this PR improves backward compatibility with earlier C# versions.
"Starting with C# 7.0, you can declare the out variable in the argument list of the method call, rather than in a separate variable declaration. " - https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/out-parameter-modifier