Skip to content

[Enhancement]Improve Camera in Lobby #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ipavlidakis
Copy link
Contributor

🎯 Goal

Improve the Camera component in Lobby.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis self-assigned this Jun 20, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner June 20, 2025 13:46
@ipavlidakis ipavlidakis added the enhancement New feature or request label Jun 20, 2025
Copy link

Public Interface

+ extension AVCaptureDevice  
+ 
+   public func outputFormat(preferredDimensions: CMVideoDimensions,preferredFrameRate: Int)-> AVCaptureDevice.Format?

+ public protocol CaptureDeviceProtocol: Sendable

+ public protocol CaptureDeviceProviding



@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jun 20, 2025

SDK Size

title develop branch diff status
StreamVideo 8.04 MB 8.06 MB +16 KB 🟢
StreamVideoSwiftUI 2.27 MB 2.26 MB -19 KB 🚀
StreamVideoUIKit 2.4 MB 2.38 MB -18 KB 🚀
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

Copy link

Public Interface

+ public protocol CaptureDeviceProviding

+ extension AVCaptureDevice  
+ 
+   public func outputFormat(preferredDimensions: CMVideoDimensions,preferredFrameRate: Int)-> AVCaptureDevice.Format?

+ public protocol CaptureDeviceProtocol: Sendable



@ipavlidakis ipavlidakis force-pushed the enhancement/improve-lobby-camera branch from 0afa24c to c7293e9 Compare June 25, 2025 20:27
Copy link

Public Interface

+ public protocol CaptureDeviceProviding

+ extension AVCaptureDevice  
+ 
+   public func outputFormat(preferredDimensions: CMVideoDimensions,preferredFrameRate: Int)-> AVCaptureDevice.Format?

+ public protocol CaptureDeviceProtocol: Sendable



Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@ipavlidakis ipavlidakis force-pushed the enhancement/improve-lobby-camera branch from c7293e9 to 4df8b76 Compare June 26, 2025 06:28
Copy link

Public Interface

+ public protocol CaptureDeviceProtocol: Sendable

+ extension AVCaptureDevice  
+ 
+   public func outputFormat(preferredDimensions: CMVideoDimensions,preferredFrameRate: Int)-> AVCaptureDevice.Format?

+ public protocol CaptureDeviceProviding



Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants