-
Notifications
You must be signed in to change notification settings - Fork 357
refactor!(ui): add support for customising reaction picker #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xsahil03x
wants to merge
45
commits into
v10.0.0
Choose a base branch
from
feat/reactions-v2
base: v10.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 12, 2025
…eat/reactions-v2 # Conflicts: # packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart # packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart # packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
This reverts commit 9551f18.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v10.0.0 #2248 +/- ##
==========================================
Coverage ? 63.44%
==========================================
Files ? 399
Lines ? 25104
Branches ? 0
==========================================
Hits ? 15927
Misses ? 9177
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart # packages/stream_chat_flutter/lib/src/message_action/message_action_type.dart # packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart # packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart # packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart # packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart # packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker.dart # packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker_icon_list.dart # packages/stream_chat_flutter/lib/src/message_widget/reactions/reactions_align.dart # packages/stream_chat_flutter/test/src/message_modal/message_reactions_modal_test.dart
Co-authored-by: xsahil03x <25670178+xsahil03x@users.noreply.github.com>
# Conflicts: # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_light.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_icon_button_selected_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_icon_button_unselected_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_picker_icon_list_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_picker_icon_list_selected_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/stream_reaction_picker_light.png # packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/stream_reaction_picker_selected_light.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_2.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_dark.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_light.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_dark.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_light.png
# Conflicts: # packages/stream_chat_flutter/lib/src/message_action/message_action_type.dart # packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart # packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart # packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart # packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart # packages/stream_chat_flutter/lib/src/message_widget/message_widget_content_components.dart # packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker.dart # packages/stream_chat_flutter/lib/src/message_widget/reactions/reactions_align.dart # packages/stream_chat_flutter/lib/src/reactions/reaction_picker_icon_list.dart # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_light.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_dark.png # packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_light.png # packages/stream_chat_flutter/test/src/message_modal/message_reactions_modal_test.dart # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_2.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_dark.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_light.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_dark.png # packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_light.png
9718aae
to
3a60f29
Compare
renefloor
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2225, #2216
Description of the pull request
This pull request Introduces a
reactionPickerBuilder
parameter inStreamMessageWidget
, enabling developers to provide custom reaction picker implementations. Also fixed the issue where overriding the reaction icons in a subtree was not getting used in the reaction picker.Screen.Recording.2025-05-26.at.02.29.35.mov