Skip to content

refactor!(ui): add support for customising reaction picker #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 45 commits into
base: v10.0.0
Choose a base branch
from

Conversation

xsahil03x
Copy link
Member

@xsahil03x xsahil03x commented May 12, 2025

Resolves: #2225, #2216

Description of the pull request

This pull request Introduces a reactionPickerBuilder parameter in StreamMessageWidget, enabling developers to provide custom reaction picker implementations. Also fixed the issue where overriding the reaction icons in a subtree was not getting used in the reaction picker.

Screen.Recording.2025-05-26.at.02.29.35.mov

@xsahil03x xsahil03x changed the title refactor(ui): add support for customising reaction picker refactor!(ui): add support for customising reaction picker May 12, 2025
xsahil03x and others added 11 commits May 12, 2025 17:15
…eat/reactions-v2

# Conflicts:
#	packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
This reverts commit 9551f18.
@xsahil03x xsahil03x marked this pull request as ready for review May 14, 2025 13:09
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 71.37809% with 81 lines in your changes missing coverage. Please review.

Please upload report for BASE (v10.0.0@08600ee). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...flutter/lib/src/message_widget/message_widget.dart 58.87% 44 Missing ⚠️
..._flutter/lib/src/reactions/reaction_indicator.dart 4.34% 22 Missing ⚠️
...r/lib/src/message_list_view/message_list_view.dart 6.66% 14 Missing ⚠️
...r/lib/src/reactions/desktop_reactions_builder.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v10.0.0    #2248   +/-   ##
==========================================
  Coverage           ?   63.44%           
==========================================
  Files              ?      399           
  Lines              ?    25104           
  Branches           ?        0           
==========================================
  Hits               ?    15927           
  Misses             ?     9177           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xsahil03x and others added 2 commits May 21, 2025 17:30
Co-authored-by: xsahil03x <25670178+xsahil03x@users.noreply.github.com>
Base automatically changed from refactor/message-actions to v10.0.0 May 22, 2025 13:37
xsahil03x and others added 9 commits May 22, 2025 16:31
# Conflicts:
#	packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart
#	packages/stream_chat_flutter/lib/src/message_action/message_action_type.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
#	packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker.dart
#	packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker_icon_list.dart
#	packages/stream_chat_flutter/lib/src/message_widget/reactions/reactions_align.dart
#	packages/stream_chat_flutter/test/src/message_modal/message_reactions_modal_test.dart
@xsahil03x xsahil03x changed the base branch from v10.0.0 to refactor/sync-theme-colors May 26, 2025 12:54
Co-authored-by: xsahil03x <25670178+xsahil03x@users.noreply.github.com>
Base automatically changed from refactor/sync-theme-colors to v10.0.0 May 26, 2025 13:18
xsahil03x and others added 2 commits May 26, 2025 15:22
# Conflicts:
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_dark.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_light.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_dark.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_icon_button_selected_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_icon_button_unselected_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_picker_icon_list_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/reaction_picker_icon_list_selected_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/stream_reaction_picker_light.png
#	packages/stream_chat_flutter/test/src/message_widget/reactions/goldens/ci/stream_reaction_picker_selected_light.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_2.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_dark.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_light.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_dark.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_light.png
# Conflicts:
#	packages/stream_chat_flutter/lib/src/message_action/message_action_type.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_actions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_modal.dart
#	packages/stream_chat_flutter/lib/src/message_modal/message_reactions_modal.dart
#	packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart
#	packages/stream_chat_flutter/lib/src/message_widget/message_widget_content_components.dart
#	packages/stream_chat_flutter/lib/src/message_widget/reactions/reaction_picker.dart
#	packages/stream_chat_flutter/lib/src/message_widget/reactions/reactions_align.dart
#	packages/stream_chat_flutter/lib/src/reactions/reaction_picker_icon_list.dart
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_dark.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_light.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_dark.png
#	packages/stream_chat_flutter/test/src/message_modal/goldens/ci/stream_message_reactions_modal_reversed_light.png
#	packages/stream_chat_flutter/test/src/message_modal/message_reactions_modal_test.dart
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_2.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_dark.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_3_light.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_dark.png
#	packages/stream_chat_flutter/test/src/misc/goldens/ci/reaction_bubble_like_light.png
@xsahil03x xsahil03x force-pushed the feat/reactions-v2 branch from 9718aae to 3a60f29 Compare May 26, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Reaction picker Reactions per channel like in React Native
2 participants