Skip to content

Conversation

@AlitaBernachot
Copy link
Contributor

@AlitaBernachot AlitaBernachot commented Sep 9, 2024

JIRA issue

https://jira.camptocamp.com/browse/GSLUX-736

Description

Fit map view to feature extent when cliking on the "search" icon in draw panel.

  • add the fit to feature extent functonality
  • add the new setThemeZooms() function (inspired by setThemeZooms from v3) to prevent max zooming on fit. Now zoom is blocked by maxZoom, a setting coming from the theme metadat (if any).
  • handle the rotation param (as in v3 setThemeZooms, but put it elsewhere and not in v4 setThemeZooms)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

GitHub Pages links: * Luxembourg-geoportail: https://geoportail-luxembourg.github.io/luxembourg-geoportail/GSLUX-736-fit-draw-feat/

for v3 compatibility and since restore expects radians
Copy link
Contributor

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AlitaBernachot! Code LGTM, I just noticed that v3 keeps rotation in radians in the URL and that the restore currently also expects radians. So I've added a commit to persist the rotation in radians. I let you merge when you are fine with it :-)

@AlitaBernachot
Copy link
Contributor Author

Thanks, @AlitaBernachot! Code LGTM, I just noticed that v3 keeps rotation in radians in the URL and that the restore currently also expects radians. So I've added a commit to persist the rotation in radians. I let you merge when you are fine with it :-)

Thx for the review and the fix on radians!

@AlitaBernachot AlitaBernachot merged commit 9341d8c into main Sep 30, 2024
2 checks passed
@AlitaBernachot AlitaBernachot deleted the GSLUX-736-fit-draw-feat branch September 30, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants