-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Small SDL3 macOS fixes #6259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Small SDL3 macOS fixes #6259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not rely on SDL to expose integer scroll values, as they are not available in all versions. It was reimplemented in SDL 3.2.12 by this commit: <libsdl-org/SDL@0447c2f> Refs Genymobile#6156 <Genymobile#6156>
Inline the function body in its only caller. This will simplify further refactors.
The texture was created as soon as the initial video size was known, even before the first frame arrived. However, texture creation will require other data, such as the color range, which is only available once the first frame is received. Therefore, delay texture creation until the first frame.
This prepares for the migration to SDL3, where the color range can only be specified at the time of texture creation.
Use both the color space and color range from FFmpeg to determine the appropriate SDL YUV conversion mode.
The latest Ubuntu does not provide the SDL3 package yet.
Thank you 👍 |
No, i'll just integrate the changes into my branch. |
The target branch can be changed by clicking the Edit button |
@yume-chan |
rom1v
pushed a commit
that referenced
this pull request
Aug 12, 2025
The field gl_context is initialized from SDL_GL_CreateContext(), which returns a raw SDL_GLContext, not a pointer. The type mismatch was silently ignored by SDL2 because SDL_GLContext was defined as an alias to `void *` (in SDL3, it is instead an alias to `struct SDL_GLContextState *`, so compilation fails). Refs #3895 <#3895> PR #6259 <#6259> Signed-off-by: Romain Vimont <rom@rom1v.com>
I merged your first commit directly into |
I fixed up the other commit into my commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gl_context
is no longer a pointermouse x,y is float
Fixes these warnings when building macOS