131_make_ocPreds_faster

[audreyyeoCH]

closes #135

[audreyyeoCH]

when sim = 50 run time 14300 ms
when sim = 15 run time 4300 ms

using profvis package to assess run time. Changing the sim = 15 instead of 50 slowed ONE example by one third.

[github-actions]

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                59       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              81       3  96.30%   32, 62, 136
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      166       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                63       5  92.06%   106-110
R/plotBounds.R              52      52  0.00%    33-90
R/plotDecision.R            79      79  0.00%    16-136
R/plotOc.R                  50       2  96.00%   94-95
R/postprob.R                34       1  97.06%   106
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                24       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumbetadiff.R             68      15  77.94%   85-103
R/sumTable.R                36       0  100.00%
TOTAL                     2344     477  79.65%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3ec8017

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

    1 files     19 suites   6m 1s ⏱️
  135 tests   134 ✅ 1 💤 0 ❌
1 298 runs  1 295 ✅ 3 💤 0 ❌

Results for commit 3ec8017.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
ocPredprobDist	💚	$169.97$	$-77.23$	$0$	$0$	$0$	$0$
plotOc	💚	$212.41$	$-4.43$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
ocPredprobDist	💚	$40.53$	$-36.62$	ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_FALSE
ocPredprobDist	💚	$45.46$	$-40.33$	ocPredprobDist_gives_correct_result_and_list_when_relativeDelta_TRUE
plotOc	💚	$56.48$	$-1.17$	h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc	💚	$104.40$	$-2.27$	plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status

Results for commit 1e9f90a

♻️ This comment has been updated with latest results.

[audreyyeoCH]

Hi @danielinteractive this is a summary of the run time
Total run time around 1h 4 mins.
Build packages and R CMD checks takes the longest, would it be better to speed it up more ? Changing sims shaved off about 2 mins.

[danielinteractive]

Thanks @audreyyeoCH , it seems the vignette build takes the majority of the time, e.g. within the check action:

Examples and tests take proportionally much less time:

So in another PR could try to address the vignettes. For now is ok here

[audreyyeoCH]

Great thanks for checking it out @danielinteractive, Would you say we can reassign this to another issue (or not?) and then merge it ?

[danielinteractive]

👍

[audreyyeoCH]

Thanks @danielinteractive !