Patching parsing issues with approval #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patscott
requested changes
Feb 14, 2025
Comment on lines
+46
to
+48
| clean_exit = False | ||
| if isinstance(err, SystemExit): | ||
| clean_exit = True if err.code == 0 else clean_exit |
There was a problem hiding this comment.
I find this construction kind of convoluted and therefore a bit difficult to follow. How about something like just
clean_exit = isinstance(err, SystemExit) and err.code == 0?
Comment on lines
+68
to
+70
| clean_exit = False | ||
| if isinstance(err, SystemExit): | ||
| clean_exit = True if err.code == 0 else clean_exit |
| lookup_key[index] = index_count | ||
| index_count += 1 | ||
| non_functional_cols = [i for i, elem in enumerate(data) if data[i] != 'functional'] | ||
| non_functional_cols = [i for i, elem in enumerate(data) if np.all(data[i] != 'functional')] # Numpy now requires the user cast to a scalar when performing boolean checks on arrays |
There was a problem hiding this comment.
This seems confusing, or at least not the optimal way to check. What's being checked for here is just whether data[i] is a string with value 'functional', or a numpy array. Better would probably be to just check if data[i] is a numpy array. Same for the following changes using np.all.
| 1. Make sure you have the following already installed: | ||
| * Either Python v2.7 or later or Python v3 | ||
| * NumPy and SciPy libraries for python (NumPy v0.9.0 or | ||
| * Either Python v2.7 or later or Python v3.8 or later |
There was a problem hiding this comment.
Does the use of packaging for versioning break compatibility with Python 2.7? If so, we should just remove 2.7 here, there's no real need to support it any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches:
I've cherry-picked the commits on top of the
revert-9-fixesbranch somastercan be fast forwarded once #10 is merged.