Skip to content

Re-Fix https://github.com/GTNewHorizons/GT-New-Horizons-Modpack/issues/1896 #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 24, 2025

Conversation

v3ect0rgames
Copy link
Contributor

This issue was fixed a while ago. However t1-t3 were in a different file from t4-8. The t4-8 file was deleted a while ago. While more recently the t1-3 file as zs was moved to the core mod. This Pr adds back the t4-8 and shuttle recipes for removing chests.

@Glease
Copy link
Contributor

Glease commented May 22, 2025

Are you sure it's GTNewHorizons/GT-New-Horizons-Modpack#1896? It's 2017 ticket and it's something quest related and not at all related to recipes.

@Dream-Master Dream-Master requested a review from a team May 22, 2025 08:53
@v3ect0rgames
Copy link
Contributor Author

the way the quest was originally fixed was by allowing all rockets to be converted into chestless rockets

@v3ect0rgames
Copy link
Contributor Author

oh shuttle doesnt have nbt or something?

@v3ect0rgames
Copy link
Contributor Author

dont review until i fix the shuttle recipe

@v3ect0rgames
Copy link
Contributor Author

I think I fixed it

@Caedis Caedis added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 23, 2025
Caedis added a commit that referenced this pull request May 23, 2025
Merged PRs:
	#1227
	#1228
	#1242
	#1261
	#1266
	#1267

Failed PRs:
	#1221: Failed to merge
	#1268: Build failed
	#1269: Build failed
@v3ect0rgames
Copy link
Contributor Author

hmm whats the problem

@v3ect0rgames
Copy link
Contributor Author

i did do import GalacticraftAmunRa

@v3ect0rgames
Copy link
Contributor Author

caedis can you re-run

@boubou19 boubou19 enabled auto-merge (squash) May 24, 2025 18:01
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label May 24, 2025
@boubou19 boubou19 merged commit 571175c into GTNewHorizons:master May 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants