Skip to content

Commit 251787e

Browse files
authored
Merge pull request #62 from GPUOpen-LibrariesAndSDKs/precomp-submodule
Precomp submodule
2 parents 2a4633c + c328f0a commit 251787e

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

.gitmodules

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[submodule "hipbin"]
2+
path = hipbin
3+
url = https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderSDKKernels

hipbin

Submodule hipbin added at a222c3e

readme.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,11 @@ This repo contains :
1616
## Install Precompiled Kernels
1717

1818
Since 3.01.00, for Northstar the default render backend is HIP ( instead of OpenCL ). \
19-
The main difference is that compute kernels are now precompiled by us. They must be downloaded from a separate link.\
19+
The main difference is that compute kernels are now precompiled by us. They must be downloaded from a submodule.\
2020
Note that for now you can still use the OpenCL backend ( with `RPR_CREATION_FLAGS_ENABLE_OPENCL` in `rprCreateContext` ). However we don't recommend it as in the future we may put less resource to support this backend.\
21-
Download the precompiled kernels here: https://www.dropbox.com/s/uojh957rxcvrc6b/hipbin_3.01.00.zip?dl=0 \
22-
In order to run tutorials, it's recommended to put the package inside tutorials/Bin/ so that it looks like that:
21+
Download the precompiled kernels with the command:
2322
```
24-
tutorials/Bin/hipbin/AllPreCompilations.json
25-
tutorials/Bin/hipbin/****.hipbin
26-
tutorials/Bin/hipbin/****.cudabin
23+
git submodule update --init --recursive
2724
```
2825

2926
The precompiled kernels folder can be modified with `RPR_CONTEXT_PRECOMPILED_BINARY_PATH`. ( for its usage, check the tutorials ).

tutorials/common/common.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ const rpr_context_properties g_contextProperties[] =
6363
{
6464

6565
// define the precompiled kernels folder.
66-
// for most of the tutorials, the path will be <working directory>/hipbin/*****.hipbin
66+
// for most of the tutorials, the path will be <working directory>../../hipbin/*****.hipbin
6767
// ( check the readme for more information about precompiled kernels )
6868
(rpr_context_properties)RPR_CONTEXT_PRECOMPILED_BINARY_PATH,
69-
(rpr_context_properties)"hipbin",
69+
(rpr_context_properties)"../../hipbin",
7070

7171
// terminate the list of properties with a NULL <property name>
7272
(rpr_context_properties)0,

0 commit comments

Comments
 (0)