Skip to content

C++17-proofing testTensor.cu #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 8, 2024
Merged

C++17-proofing testTensor.cu #30

merged 17 commits into from
May 8, 2024

Conversation

alphaville
Copy link
Member

@alphaville alphaville commented May 8, 2024 •
edited
Loading

Main Changes

Quick fix for the tests to work on Orin. Using TEMPLATE_WITH_TYPE_T and TEMPLATE_CONSTRAINT_REQUIRES_FPX where necessary.

I updated CMakeLists.txt. To compile on A40 do:

cmake .

to compile on Orin, do:

cmake -DCPPVERSION=17 -DSM_ARCH=87 .

Also: CI runs on Orin too now.

Associated Issues

@alphaville alphaville requested a review from ruairimoran May 8, 2024 10:29
@alphaville alphaville mentioned this pull request May 8, 2024
Merged
ruairimoran
ruairimoran approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ruairimoran ruairimoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alphaville alphaville merged commit b3aa3cb into main May 8, 2024
2 checks passed
@alphaville alphaville deleted the hf/28-compilation-on-orin branch May 8, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruairimoran ruairimoran ruairimoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warnings Compilation on Jetson Orin
2 participants
@alphaville @ruairimoran