-
Notifications
You must be signed in to change notification settings - Fork 0
docs: Add Paraview Proxy examples #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this work, it will be very useful.
I made a lots of suggestions, but they are basically all the same, just formatting.
geos_pv_path: Path = Path( __file__ ).parent.parent | ||
sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
from geos.pv.utils.config import update_paths | ||
|
||
update_paths() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in #81, do we keep this system of paths in the code or not ? This is not clear to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we must include the paths for PV plugins (see the answer in #81 for more details).
# update sys.path to load all GEOS Python Package dependencies | ||
geos_pv_path: Path = Path( __file__ ).parent.parent | ||
sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
from geos.pv.utils.config import update_paths | ||
|
||
update_paths() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark for paths
geos_pv_path: Path = Path( __file__ ).parent.parent | ||
sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
from geos.pv.utils.config import update_paths | ||
|
||
update_paths() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark for paths
# update sys.path to load all GEOS Python Package dependencies | ||
geos_pv_path: Path = Path( __file__ ).parent.parent | ||
sys.path.insert( 0, str( geos_pv_path / "src" ) ) | ||
from geos.pv.utils.config import update_paths | ||
|
||
update_paths() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark for paths
__doc__ = """ | ||
Example of a Paraview plugin that runs through time steps. | ||
|
||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation does not explain what "running through time steps" means
panel_visibility="default"> | ||
<Property name="BoolSingle"/> | ||
</PropertyGroup>""" ) | ||
def c03BoolInputsGroup( self: Self ) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be c05BoolInputsGroup
* Add Paraview Proxy examples * linting, formating, typing
This PR adds examples of Paraview plugins.