Skip to content

feat: add scalar array selection in geos-trame #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lucas-givord
Copy link
Contributor

Add in the Deck Viewer the ability to pick a specific scalar array

close #102

@lucas-givord lucas-givord self-assigned this Jun 10, 2025
@lucas-givord lucas-givord force-pushed the lgivord/feature/add-scalar-arrays branch from fc10795 to 1e24a93 Compare June 10, 2025 12:08
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @alexbenedicto, should I have to push this data with git lfs? If I do that, I believe I'll hit this issue once again : #83 (comment), wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lucas-givord , you are right. There is no available credit for git lfs. Do you need to add this .vtu to tests your functionalities ? With this size ?
I have asked the GEOS devs in charge of the project and they highly suggest to minimize the amount of data that will need to use git lfs and the size of test cases as much as possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, we should be able to reduce the data. I think I'll add *.vtu in the .gitattributes.

I notice several other *.vtu in this repository :

image

Do you think it will be worth to open an issue regarding this git lfs limitation ?

FYI @margauxraguenel @paloma-martinez

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can reduce the data to 4.0K, however we hit the lfs limit when I tried to push to the repository. I guess we only have 2 options ?

  • push the data without lfs
  • upgrade lfs storage

@alexbenedicto let me know how you want me to proceed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was told that there are currently no lfs credits left in the whole repository right now. So you can push this data without lfs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add scalar array selection in the Viewer
3 participants