-
Notifications
You must be signed in to change notification settings - Fork 95
feat: data structure for enabling capillary interface conditions #3657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rrsettgast
wants to merge
77
commits into
CapillaryInterfaceConditions
Choose a base branch
from
feature/capillaryInterfaceConditionsDataStructure
base: CapillaryInterfaceConditions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: data structure for enabling capillary interface conditions #3657
rrsettgast
wants to merge
77
commits into
CapillaryInterfaceConditions
from
feature/capillaryInterfaceConditionsDataStructure
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrsettgast
commented
May 13, 2025
Comment on lines
1599
to
1609
dhalfFlux_dP[ip][ix + ke] = sign[0] * sign[ip] * (dMob_dP[0][ke] * mobility[0] - dMob_dP[1][ke] * mobility[1]) / (total_mobility * total_mobility) * uT; // dF/dP | ||
// = | ||
// { | ||
// T | ||
// + | ||
// dT/dP1 | ||
// * | ||
// (P1 | ||
// - | ||
// P2) | ||
// , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happened here?
… feature/capillaryInterfaceConditionsDataStructure
…llaryInterfaceConditionsDataStructure
…erfaceConditionsDataStructure
…onverges for viscous, gravity, and capillary fluxes
…llaryInterfaceConditionsDataStructure
Introducing an alternative container m_connectorIndicesByInterfaceRegion this implies call the nonlinear interface solver in a separate call
* Update StencilBase.hpp
…ttps://github.com/GEOS-DEV/GEOS into feature/capillaryInterfaceConditionsDataStructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
FaceElementSubRegion
entries for interface "face sets"FaceElementSubRegion
corresponding to each side of the interface.