Skip to content

fix the error in the jumps calculation with minimal_residence #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

fix the error in the jumps calculation with minimal_residence #369

merged 4 commits into from
Apr 10, 2025

Conversation

v1kko
Copy link
Contributor

@v1kko v1kko commented Apr 10, 2025

it is now correctly taken into account

@v1kko v1kko requested a review from stefsmeets April 10, 2025 12:52
stefsmeets
stefsmeets approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@stefsmeets stefsmeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1kko v1kko merged commit 63a221c into main Apr 10, 2025
4 checks passed
@v1kko v1kko deleted the fix_jumps_minimal_residence branch April 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefsmeets stefsmeets stefsmeets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v1kko @stefsmeets