Skip to content

Fix vibration amplitudes plot #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Conversation

stefsmeets
Copy link
Contributor

@stefsmeets stefsmeets commented Oct 14, 2024

This PR updates the vibratitonal amplitudes plot so that the matplotlib version matches the plotly version.

Closes #335

Todo

  • Fix mypy issue with matplotlib.figure.Figure
  • Add n_parts support
  • Plot error bars on mpl function
  • Check consistency of all other plotly/mpl plots

@stefsmeets
Copy link
Contributor Author

stefsmeets commented Oct 14, 2024

Plots are now generated in exactly the same way, and should produce the same histogram (including error bars if n_parts>1:

@stefsmeets stefsmeets marked this pull request as ready for review October 14, 2024 13:38
@stefsmeets stefsmeets merged commit 7744b28 into main Oct 14, 2024
3 of 4 checks passed
@stefsmeets stefsmeets deleted the fix-vibration-amplitudes-plot branch October 14, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot vibrational amplitudes
1 participant