Skip to content

feat: Implements remote config support and config reload feature #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 62 commits into from

Conversation

dcoric
Copy link
Collaborator

@dcoric dcoric commented Feb 12, 2025

This pull request introduces enhancements to the GitProxy configuration management, including the ability to reload configurations dynamically without restarting the service, and support for multiple configuration sources. The key changes are:

  • Added support for multiple configuration sources in config.schema.json and proxy.config.json, including file, HTTP, and Git sources
  • Introduced a new ConfigLoader class in src/config/ConfigLoader.js to handle loading and merging configurations from different sources, with support for periodic reloads.
  • Updated src/config/index.js to use the new ConfigLoader for managing configuration updates and reloading.
  • Added a new reload-config command to the CLI in packages/git-proxy-cli/index.js to trigger configuration reloads.
  • Introduced a new admin-only API endpoint in src/service/index.js to reload the configuration and restart services.

@dcoric dcoric force-pushed the denis-coric/remote-config branch from df0f681 to f8ba062 Compare February 27, 2025 23:49
Copy link

github-actions bot commented Feb 27, 2025

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.

View full job summary

@dcoric dcoric force-pushed the denis-coric/remote-config branch from f8ba062 to d9b5b5f Compare February 28, 2025 09:24
@dcoric dcoric self-assigned this Mar 5, 2025
@dcoric dcoric force-pushed the denis-coric/remote-config branch from 72fb681 to b6737c9 Compare March 5, 2025 13:10
@dcoric dcoric changed the title Implements remote config support and config reload feature feat: Implements remote config support and config reload feature Mar 5, 2025
@dcoric dcoric force-pushed the denis-coric/remote-config branch 2 times, most recently from 2a66b4a to aa0283d Compare March 10, 2025 11:56
@dcoric dcoric force-pushed the denis-coric/remote-config branch from aa0283d to 8d161a6 Compare March 25, 2025 13:57
@dcoric dcoric force-pushed the denis-coric/remote-config branch 2 times, most recently from 7f0a5cf to a73338d Compare April 8, 2025 19:47
renovate bot and others added 14 commits April 28, 2025 07:47
fix(deps): update npm - li-cli - experimental/li-cli/package.json
chore(deps): update github-actions - workflows - .github/workflows/dependency-review.yml
chore: bump by minor to v1.11.0
chore: switch @typescript-eslint/no-explicit-any to off instead of warn
…y-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager

chore(deps): update dependency @finos/git-proxy to ^1.11.0 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
@dcoric dcoric force-pushed the denis-coric/remote-config branch 2 times, most recently from 2e882cf to e820169 Compare May 19, 2025 12:42
StingRayZA and others added 19 commits May 19, 2025 13:47
Signed-off-by: stingrayza <rhook@gitlab.com>
add meeting minutes GitHub Issue template
fix(deps): update dependency eslint to ^9.27.0 - website - website/package.json
chore(deps): update github-actions - workflows - .github/workflows/dependency-review.yml
feat: converted to typescript

fix: config loader clone command issue

fix: adds input validation, uses array arguments, prevented shell spawn

fix: adds failsafe checking for directory location and structure

fix: env-paths change to v2.2.1 which support require and minor code fix

fix: improves test coverage

Adds additional tests for better cove

fix: fixed creating cache directory
Default value should be false, and set to true when cert path is configured
@dcoric dcoric force-pushed the denis-coric/remote-config branch from 41697aa to a4cfa78 Compare May 20, 2025 13:12
@dave-gantenbein
Copy link

Duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for the configuration to be sourced externally and updated at runtime
7 participants