use leveldb #6
Open
use leveldb #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 73.27% 75.52% +2.25%
==========================================
Files 21 21
Lines 1145 993 -152
Branches 118 101 -17
==========================================
- Hits 839 750 -89
+ Misses 272 221 -51
+ Partials 34 22 -12
Continue to review full report at Codecov.
|
ohtake
requested changes
Dec 13, 2017
server-websocket.js
Outdated
| @@ -31,14 +47,15 @@ const server = http.createServer((req, res) => { | |||
| const io = socketIo.listen(server); | |||
|
|
|||
| const yInstances = {}; | |||
| const metadata = {}; | |||
| const dirs = getDirectories('y-leveldb-databases/').map(p => p.split('/')[1]); | |||
There was a problem hiding this comment.
I wonder if this line is platform-independent.
|
Security issue: If a user creates a page named '..', LevelDB creates files outside 'y-leveldb-databases' directory. |
ohtake
force-pushed
the
leveldb
branch
5 times, most recently
from
c9fbcbc to
fe5ccfa
Compare
|
Changes Unknown when pulling 76f997e on leveldb into ** on master**. |
ohtake
approved these changes
Jan 16, 2018
|
The security issue was fixed by commit "Escape LevalDB namespaces". If following items become clear, we can merge the PR.
|
ohtake
force-pushed
the
leveldb
branch
2 times, most recently
from
a58c5b2 to
4333f12
Compare
ohtake
force-pushed
the
leveldb
branch
2 times, most recently
from
f2e6ab0 to
b6f95e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.