chore(messenger): use Messenger instrumentation

composer.json

@@ -33,9 +33,11 @@
         "open-telemetry/sdk": "^1",
         "open-telemetry/sem-conv": "^1",
         "open-telemetry/symfony-sdk-bundle": "^0",
+        "symfony/amqp-messenger": "^7.2",
         "symfony/config": "^7.2",
         "symfony/dependency-injection": "^7.2",
         "symfony/event-dispatcher": "^7.2",
+        "symfony/messenger": "^7.2",
         "zenstruck/dsn": "^0.2",
         "zenstruck/uri": "^2.3"
     },
@@ -67,7 +69,6 @@
         "symfony/http-client": "^7.2",
         "symfony/http-kernel": "^7.2",
         "symfony/mailer": "^7.2",
-        "symfony/messenger": "^7.2",
         "symfony/monolog-bundle": "^3.10",
         "symfony/phpunit-bridge": "^7.2",
         "symfony/runtime": "^7.2",

src/DependencyInjection/Compiler/SetInstrumentationTypePass.php

@@ -27,7 +27,10 @@ public function process(ContainerBuilder $container): void
 
         if ($container->hasParameter('open_telemetry.instrumentation.messenger.type')) {
             $messengerInstrumentationType = $container->getParameter('open_telemetry.instrumentation.messenger.type');
-            if ($container->hasDefinition('open_telemetry.instrumentation.http_kernel.trace.event_subscriber')) {
+
+            if ($container->hasDefinition('open_telemetry.instrumentation.messenger')) {
+                $container->getDefinition('open_telemetry.instrumentation.messenger')
+                    ->addMethodCall('setInstrumentationType', [$messengerInstrumentationType]);
             }
         }
     }

src/DependencyInjection/OpenTelemetryExtension.php

@@ -260,6 +260,7 @@ private function registerMessengerTracingInstrumentationConfiguration(ContainerB
             $container->removeDefinition('open_telemetry.instrumentation.messenger.trace.transport');
             $container->removeDefinition('open_telemetry.instrumentation.messenger.trace.transport_factory');
             $container->removeDefinition('open_telemetry.instrumentation.messenger.trace.middleware');
+            $container->removeDefinition('open_telemetry.instrumentation.messenger');
         }
 
         $this->setTracingInstrumentationParams($container, 'messenger', $config, $isConfigEnabled);

src/Instrumentation/Symfony/Console/TraceableConsoleEventSubscriber.php

@@ -30,6 +30,13 @@ final class TraceableConsoleEventSubscriber implements EventSubscriberInterface,
      */
     private array $excludeCommands = [];
 
+    /**
+     * @var string[]
+     */
+    private array $notSupportedCommands = [
+        'messenger:consume', // designed to run indefinitely
+    ];
+
     public function __construct(
         private readonly TracerInterface $tracer,
         /** @var ServiceLocator<TracerInterface> */
@@ -56,6 +63,9 @@ public static function getSubscribedEvents(): array
         ];
     }
 
+    /**
+     * @return class-string[]
+     */
     public static function getSubscribedServices(): array
     {
         return [TracerInterface::class];
@@ -67,6 +77,10 @@ public function startSpan(ConsoleCommandEvent $event): void
 
         assert($command instanceof Command);
 
+        if ($this->isNotSupported($command)) {
+            return;
+        }
+
         if (false === $this->isAutoTraceable($command) && false === $this->isAttributeTraceable($command)) {
             return;
         }
@@ -173,6 +187,11 @@ private function isAutoTraceable(Command $command): bool
         return true;
     }
 
+    private function isNotSupported(Command $command): bool
+    {
+        return in_array($command->getName(), $this->notSupportedCommands, true);
+    }
+
     private function isAttributeTraceable(Command $command): bool
     {
         $traceable = $this->parseAttribute($command);

src/Instrumentation/Symfony/Messenger/Amqp/AddStampForPropagationMiddleware.php

@@ -0,0 +1,45 @@
+<?php
+
+namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\Amqp;
+
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Context\Propagator\TraceStampPropagator;
+use OpenTelemetry\Context\Context;
+use OpenTelemetry\Context\Propagation\MultiTextMapPropagator;
+use Psr\Log\LoggerInterface;
+use Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpStamp;
+use Symfony\Component\Messenger\Envelope;
+use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
+use Symfony\Component\Messenger\Middleware\StackInterface;
+
+/**
+ * Be aware the app consuming the message must be able to denormalize the stamp.
+ */
+readonly class AddStampForPropagationMiddleware implements MiddlewareInterface
+{
+    public function __construct(
+        private MultiTextMapPropagator $propagator,
+        private ?LoggerInterface $logger = null,
+    ) {
+    }
+
+    public function handle(Envelope $envelope, StackInterface $stack): Envelope
+    {
+        if (null !== $envelope->last(AmqpStamp::class)) {
+            $this->onMessageSent($envelope);
+        }
+
+        return $stack->next()->handle($envelope, $stack);
+    }
+
+    private function onMessageSent(Envelope &$envelope): void
+    {
+        $scope = Context::storage()->scope();
+
+        if (null === $scope) {
+            $this->logger?->debug('No active scope');
+        }
+
+        $this->propagator->inject($envelope, new TraceStampPropagator(), Context::getCurrent());
+        $this->logger?->debug('Trace stamp added to envelope for propagation');
+    }
+}

src/Instrumentation/Symfony/Messenger/InstrumentationEventSubscriber.php

@@ -0,0 +1,128 @@
+<?php
+
+namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger;
+
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\InstrumentationTypeEnum;
+use OpenTelemetry\API\Trace\SpanKind;
+use OpenTelemetry\API\Trace\StatusCode;
+use OpenTelemetry\API\Trace\TracerInterface;
+use OpenTelemetry\Context\Context;
+use OpenTelemetry\SDK\Trace\Span;
+use Psr\Log\LoggerInterface;
+use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+use Symfony\Component\Messenger\Event\WorkerMessageFailedEvent;
+use Symfony\Component\Messenger\Event\WorkerMessageHandledEvent;
+use Symfony\Component\Messenger\Event\WorkerMessageReceivedEvent;
+use Symfony\Component\Messenger\Stamp\BusNameStamp;
+
+/**
+ * Be aware if you start a span before this subscriber, it could leads to orphan span issue.
+ * Be sure your span is properly ended.
+ */
+class InstrumentationEventSubscriber implements EventSubscriberInterface
+{
+    private ?InstrumentationTypeEnum $instrumentationType = null;
+
+    public function __construct(
+        private readonly TracerInterface $tracer,
+        private readonly LoggerInterface $logger,
+    ) {
+    }
+
+    public function setInstrumentationType(InstrumentationTypeEnum $instrumentationType): void
+    {
+        $this->instrumentationType = $instrumentationType;
+    }
+
+    public static function getSubscribedEvents()
+    {
+        return [
+            WorkerMessageReceivedEvent::class => ['startSpan'],
+            WorkerMessageFailedEvent::class => ['endSpanOnError'],
+            WorkerMessageHandledEvent::class => ['endSpanWithSuccess'],
+        ];
+    }
+
+    public function startSpan(WorkerMessageReceivedEvent $event): void
+    {
+        if (InstrumentationTypeEnum::Auto !== $this->instrumentationType) {
+            return;
+        }
+
+        $scope = Context::storage()->scope();
+
+        if (null !== $scope) {
+            $this->logger->debug(sprintf('Using scope "%s"', spl_object_id($scope)));
+        } else {
+            $this->logger->debug('No active scope');
+        }
+
+        $context = Context::getCurrent();
+        $span = $this->tracer
+            ->spanBuilder($event->getReceiverName())
+            ->setParent($context)
+            ->setSpanKind(SpanKind::KIND_CONSUMER)
+            ->startSpan();
+
+        $busNameStamp = $event->getEnvelope()->last(BusNameStamp::class);
+
+        if (null !== $busNameStamp) {
+            $span->setAttribute('bus.name', $busNameStamp->getBusName());
+        }
+
+        $this->logger->debug(sprintf('Starting span "%s"', $span->getContext()->getSpanId()));
+
+        Context::storage()
+            ->attach(
+                $span->storeInContext($context)
+            )
+        ;
+    }
+
+    public function endSpanWithSuccess(WorkerMessageHandledEvent $event): void
+    {
+        if (InstrumentationTypeEnum::Auto !== $this->instrumentationType) {
+            return;
+        }
+
+        $scope = Context::storage()->scope();
+
+        if (null === $scope) {
+            return;
+        }
+
+        $scope->detach();
+
+        $span = Span::fromContext($scope->context());
+        $span->setStatus(StatusCode::STATUS_OK);
+        $this->logger->debug(sprintf('Ending span "%s"', $span->getContext()->getSpanId()));
+        $span->end();
+    }
+
+    public function endSpanOnError(WorkerMessageFailedEvent $event): void
+    {
+        if (InstrumentationTypeEnum::Auto !== $this->instrumentationType) {
+            return;
+        }
+
+        $scope = Context::storage()->scope();
+
+        if (null === $scope) {
+            return;
+        }
+
+        $scope->detach();
+
+        $span = Span::fromContext($scope->context());
+        $span->setStatus(StatusCode::STATUS_ERROR);
+        $span->setAttribute('exception.message', $event->getThrowable()->getMessage());
+        $previous = $event->getThrowable()->getPrevious();
+
+        if (null !== $previous) {
+            $span->setAttribute('exception.previous.message', $previous->getMessage());
+        }
+
+        $this->logger->debug(sprintf('Ending span "%s"', $span->getContext()->getSpanId()));
+        $span->end();
+    }
+}

src/Instrumentation/Symfony/Messenger/TraceStamp.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger;
+
+use Symfony\Component\Messenger\Stamp\StampInterface;
+
+/**
+ * @doc: https://www.w3.org/TR/trace-context/
+ *
+ * You can see how the trace parent generated here: https://github.com/open-telemetry/opentelemetry-php/blob/main/src/API/Trace/Propagation/TraceContextPropagator.php
+ */
+readonly class TraceStamp implements StampInterface
+{
+    public function __construct(
+        private string $traceParent,
+    ) {
+    }
+
+    public function getTraceParent(): string
+    {
+        return $this->traceParent;
+    }
+}

src/OpenTelemetry/Context/Propagator/PropagatorFactory.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Context\Propagator;
+
+use OpenTelemetry\API\Baggage\Propagation\BaggagePropagator;
+use OpenTelemetry\API\Trace\Propagation\TraceContextPropagator;
+use OpenTelemetry\Context\Propagation\MultiTextMapPropagator;
+
+class PropagatorFactory
+{
+    /**
+     * Default propagators from https://opentelemetry.io/docs/specs/otel/configuration/sdk-environment-variables/#general-sdk-configuration.
+     */
+    public static function createDefault(): MultiTextMapPropagator
+    {
+        return new MultiTextMapPropagator([
+            BaggagePropagator::getInstance(),
+            TraceContextPropagator::getInstance(),
+        ]);
+    }
+}

src/OpenTelemetry/Context/Propagator/TraceStampPropagator.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Context\Propagator;
+
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\TraceStamp;
+use OpenTelemetry\API\Trace\Propagation\TraceContextPropagator;
+use OpenTelemetry\Context\Propagation\PropagationSetterInterface;
+use Symfony\Component\Messenger\Envelope;
+
+class TraceStampPropagator implements PropagationSetterInterface
+{
+    /**
+     * @param mixed $carrier
+     */
+    public function set(&$carrier, string $key, string $value): void
+    {
+        if (!$carrier instanceof Envelope) {
+            throw new \InvalidArgumentException(sprintf('The carrier for trace stamp propagation must be instance of %s', Envelope::class));
+        }
+
+        if (TraceContextPropagator::TRACEPARENT !== $key) {
+            return;
+        }
+
+        $carrier = $carrier->with(new TraceStamp($value));
+    }
+}

src/Resources/config/services.php

@@ -1,6 +1,7 @@
 <?php
 
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Context\Propagator\HeadersPropagator as HeadersPropagationGetter;
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Context\Propagator\PropagatorFactory;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\ExporterDsn;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Exporter\OtlpExporterOptions;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\OpenTelemetry\Resource\ResourceInfoFactory;
@@ -33,6 +34,7 @@
 
         ->set('open_telemetry.propagator_text_map.noop', NoopTextMapPropagator::class)
         ->set('open_telemetry.propagator_text_map.multi', MultiTextMapPropagator::class)
+            ->factory([PropagatorFactory::class, 'createDefault'])
 
         ->set('open_telemetry.propagation_getter.headers', HeadersPropagationGetter::class)
         ->set('open_telemetry.propagation_getter.sanitize_combined_headers', SanitizeCombinedHeadersPropagationGetter::class)

src/Resources/config/services_tracing_instrumentation.php

@@ -9,6 +9,8 @@
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\HttpKernel\TraceableHttpKernelEventSubscriber;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Mailer\TraceableMailer;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Mailer\TraceableMailerTransport;
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\Amqp\AddStampForPropagationMiddleware;
+use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\InstrumentationEventSubscriber;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\TraceableMessengerMiddleware;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\TraceableMessengerTransport;
 use FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\TraceableMessengerTransportFactory;
@@ -103,6 +105,16 @@
             ->tag('monolog.logger', ['channel' => 'open_telemetry'])
         ->alias('messenger.middleware.open_telemetry_tracer', 'open_telemetry.instrumentation.messenger.trace.middleware')
 
+        ->set('open_telemetry.instrumentation.messenger.propagation.amqp.middleware', AddStampForPropagationMiddleware::class)
+            ->arg('$propagator', service('open_telemetry.propagator_text_map.multi'))
+            ->tag('messenger.middleware')
+            ->tag('monolog.logger', ['channel' => 'open_telemetry'])
+
+        ->set('open_telemetry.instrumentation.messenger', InstrumentationEventSubscriber::class)
+            ->arg('$tracer', service('open_telemetry.traces.default_tracer'))
+            ->tag('monolog.logger', ['channel' => 'open_telemetry'])
+            ->tag('kernel.event_subscriber')
+
         // Twig
         ->set('open_telemetry.instrumentation.twig.trace.extension', TraceableTwigExtension::class)
             ->arg('$tracer', service('open_telemetry.traces.default_tracer'))