chore(messenger): add trace parent in dispatched messages (AMQP) #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'd like to submit to you that PR.
Handling propagation of trace in AMQP context by adding custom stamp to dispatched messages. The stamp contains the trace parent normalized by OpenTelemetry. It does not read the stamp from incoming message (must be done in another PR or in this one if you prefer).
An exemple with a message dispatched to RabbitMQ:
X-Message-Stamp-FriendsOfOpenTelemetry\OpenTelemetryBundle\Instrumentation\Symfony\Messenger\TraceStamp: [{"traceParent":"00-57cdad60c0711de6da2ab8814fc91e36-c6bb8daefdd291b0-01"}]
Add the middleware
open_telemetry.instrumentation.messenger.propagation.amqp.middleware
to your bus to activate it. e.g.I prefer writing tests once modifications are OK for you. But I can add them asap if you prefer.