Skip to content

Move demo into monorepo workspace #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions Example/ios/Podfile.lock → examples/demo/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ DEPENDENCIES:
- React-jsiexecutor (from `../node_modules/react-native/ReactCommon/jsiexecutor`)
- React-jsinspector (from `../node_modules/react-native/ReactCommon/jsinspector`)
- React-logger (from `../node_modules/react-native/ReactCommon/logger`)
- react-native-app-auth (from `../node_modules/react-native-app-auth`)
- react-native-app-auth (from `../../../node_modules/react-native-app-auth`)
- React-NativeModulesApple (from `../node_modules/react-native/ReactCommon/react/nativemodule/core/platform/ios`)
- React-perflogger (from `../node_modules/react-native/ReactCommon/reactperflogger`)
- React-RCTActionSheet (from `../node_modules/react-native/Libraries/ActionSheetIOS`)
Expand Down Expand Up @@ -533,7 +533,7 @@ EXTERNAL SOURCES:
React-logger:
:path: "../node_modules/react-native/ReactCommon/logger"
react-native-app-auth:
:path: "../node_modules/react-native-app-auth"
:path: "../../../node_modules/react-native-app-auth"
React-NativeModulesApple:
:path: "../node_modules/react-native/ReactCommon/react/nativemodule/core/platform/ios"
React-perflogger:
Expand Down Expand Up @@ -596,7 +596,7 @@ SPEC CHECKSUMS:
React-jsiexecutor: c7f826e40fa9cab5d37cab6130b1af237332b594
React-jsinspector: aaed4cf551c4a1c98092436518c2d267b13a673f
React-logger: da1ebe05ae06eb6db4b162202faeafac4b435e77
react-native-app-auth: 63fa4e58c5bd29aeb974d3a06a23c5858322d533
react-native-app-auth: 5b7f3a2ab665666ae7169b8ccda984ab51252699
React-NativeModulesApple: edb5ace14f73f4969df6e7b1f3e41bef0012740f
React-perflogger: 496a1a3dc6737f964107cb3ddae7f9e265ddda58
React-RCTActionSheet: 02904b932b50e680f4e26e7a686b33ebf7ef3c00
Expand Down
File renamed without changes.
File renamed without changes.
5 changes: 3 additions & 2 deletions Example/metro.config.js → examples/demo/metro.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const {getDefaultConfig, mergeConfig} = require('@react-native/metro-config');
const path = require('path');

const packagePath = path.resolve(
path.join(__dirname, '..', 'packages', 'react-native-app-auth'),
path.join(process.cwd(), '..', '..', 'packages', 'react-native-app-auth'),
);

const extraNodeModules = {
Expand All @@ -23,8 +23,9 @@ const config = {
get: (target, name) =>
name in target
? target[name]
: path.join(process.cwd(), `node_modules/${name}`),
: path.join(process.cwd(), '..', '..', 'node_modules', name),
}),
unstable_enableSymlinks: true,
},
watchFolders,
};
Expand Down
4 changes: 2 additions & 2 deletions Example/package.json → examples/demo/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rnaa-demo",
"version": "0.0.1",
"version": "1.0.0",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand All @@ -12,7 +12,7 @@
"dependencies": {
"react": "18.2.0",
"react-native": "0.72.4",
"react-native-app-auth": "link:../packages/react-native-app-auth"
"react-native-app-auth": "*"
},
"devDependencies": {
"@babel/core": "^7.20.0",
Expand Down
File renamed without changes.
34 changes: 30 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,35 @@
"scripts": {
"changeset": "changeset",
"lint": "yarn workspace react-native-app-auth lint",
"test": "yarn workspace react-native-app-auth test"
"test": "yarn workspace react-native-app-auth test",
"start:demo:android": "yarn workspace rnaa-demo android",
"start:demo:ios": "yarn workspace rnaa-demo ios"
},
"workspaces": [
"packages/*"
]
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@svitejs/changesets-changelog-github-compact": "^0.1.1",
"babel-eslint": "10.0.3",
"eslint": "6.8.0",
"eslint-config-formidable": "4.0.0",
"eslint-config-prettier": "6.9.0",
"eslint-plugin-filenames": "1.3.2",
"eslint-plugin-import": "2.19.1",
"eslint-plugin-jest": "23.3.0",
"eslint-plugin-prettier": "3.1.2",
"eslint-plugin-promise": "4.2.1",
"prettier": "1.19.1"
},
"workspaces": {
"packages": [
"packages/*",
"examples/*"
],
"nohoist": [
"**/react-native",
"**/react-native/**",
"**/@react-native",
"**/@react-native/**",
"**/react-native-app-auth/**"
]
}
}
12 changes: 0 additions & 12 deletions packages/react-native-app-auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,7 @@
"react-native": ">=0.63.0"
},
"devDependencies": {
"@changesets/cli": "^2.26.1",
"@svitejs/changesets-changelog-github-compact": "^0.1.1",
"babel-eslint": "10.0.3",
"eslint": "6.8.0",
"eslint-config-formidable": "4.0.0",
"eslint-config-prettier": "6.9.0",
"eslint-plugin-filenames": "1.3.2",
"eslint-plugin-import": "2.19.1",
"eslint-plugin-jest": "23.3.0",
"eslint-plugin-prettier": "3.1.2",
"eslint-plugin-promise": "4.2.1",
"jest": "24.9.0",
"prettier": "1.19.1",
"react": "16.9.0",
"react-native": "0.63.0"
},
Expand Down
Loading