Skip to content

feat(inbox): add new route post for inbox feature #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2025
Merged

feat(inbox): add new route post for inbox feature #713

merged 3 commits into from
Feb 4, 2025

Conversation

nicolasalexandre9
Copy link
Member

@nicolasalexandre9 nicolasalexandre9 commented Jan 31, 2025 •
edited by VincentMolinie
Loading

Definition of Done

CU-86c1wfju1

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@forest-bot
Copy link
Member

Task linked: CU-86c1wfju1 Filters - Users want unlimited filters size

VincentMolinie
VincentMolinie requested changes Jan 31, 2025
View reviewed changes
@nbouliol
Copy link
Member

When we send page page[size]:1 it's not applied because I have 6 records returned 😅

image image

@nicolasalexandre9
Copy link
Member Author

nicolasalexandre9 commented Feb 3, 2025 •
edited
Loading

@nbouliol, I just test the pagination and it's work on my end

{ "fields": { "Category": "created_at,id,label,updated_at" }, "page": { "number": 2, "size": 1 } }

@VincentMolinie
Copy link
Member

Can you update the url please @nicolasalexandre9 🙏 😘

@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 3, 2025

Code Climate has analyzed commit 9058dfb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 51.8%.

View more on Code Climate.

nbouliol
nbouliol approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@nbouliol nbouliol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with the frontend version https://github.com/ForestAdmin/forestadmin/pull/8250

@nicolasalexandre9 nicolasalexandre9 merged commit acf6f22 into main Feb 4, 2025
6 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the feat/add-inbox-route branch February 4, 2025 08:40
forest-bot added a commit that referenced this pull request Feb 4, 2025
@forest-bot
chore(release): 9.8.0 [skip ci]
8109ef6 
# [9.8.0](v9.7.0...v9.8.0) (2025-02-04)

### Features

* **inbox:** add new route post for inbox feature ([#713](#713)) ([acf6f22](acf6f22))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentMolinie VincentMolinie VincentMolinie requested changes

@nbouliol nbouliol nbouliol approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolasalexandre9 @forest-bot @nbouliol @VincentMolinie