Skip to content

feat(smart-field): set filterable and sortable options at true by default on polymorphic smart field #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@nicolasalexandre9 nicolasalexandre9 changed the title feat(smart-field): set filterable and sortable polymorphic smart field by default feat(smart-field): set filterable and sortable options at true by default on polymorphic smart field Nov 15, 2024
@nicolasalexandre9
Copy link
Member Author

Hi @lostie,

I've opened this PR that sets the filterable and sortable options to true by default when the smart field added is a polymorphic field.
You can take a look at it and feel free to comment if you have any.

Copy link
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasalexandre9 nicolasalexandre9 force-pushed the feat/enabled-filter-and-sort-on-polymorphic-field branch from 47d451c to 9bfe57b Compare December 10, 2024 08:48
Copy link

codeclimate bot commented Dec 10, 2024

Code Climate has analyzed commit 9bfe57b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 83.3% (55% is the threshold).

This pull request will bring the total coverage in the repository to 51.5%.

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 merged commit 7f9de48 into main Dec 10, 2024
6 checks passed
@nicolasalexandre9 nicolasalexandre9 deleted the feat/enabled-filter-and-sort-on-polymorphic-field branch December 10, 2024 08:58
forest-bot added a commit that referenced this pull request Dec 10, 2024
# [9.6.0](v9.5.7...v9.6.0) (2024-12-10)

### Features

* **smart-field:** set filterable and sortable options at true by default on polymorphic smart field ([#697](#697)) ([7f9de48](7f9de48))
@forest-bot
Copy link
Member

🎉 This PR is included in version 9.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants