Skip to content

Commit cd56ed4

Browse files
committed
Revert "fix half of 125"
This reverts commit 18fdd64.
1 parent 18fdd64 commit cd56ed4

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/lib/array.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,7 @@ end
171171

172172
for i = 0:2, c = combinations([:AbstractArray, :TrackedArray, :Number], i), f = [:hcat, :vcat]
173173
cnames = map(_ -> gensym(), c)
174-
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::AbstractArray...) =
175-
track($f, $(cnames...), x, xs...)
176-
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::Number...) =
174+
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::Union{AbstractArray,Number}...) =
177175
track($f, $(cnames...), x, xs...)
178176
end
179177

test/tracker.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,9 @@ end
129129

130130
@testset "scalars" begin
131131
@test vcat(param([1, 2, 3]), 1) isa TrackedArray
132-
@test vcat(param(1), 2) isa TrackedArray
133-
134-
# These two are ambiguity errors on Julia 1.8
135132
@test vcat(1, param([1, 2, 3])) isa TrackedArray
136133
@test hcat(1, param([1 2 3;])) isa TrackedArray
134+
@test vcat(param(1), 2) isa TrackedArray
137135
end
138136

139137
end

0 commit comments

Comments
 (0)