Skip to content

Commit 18fdd64

Browse files
committed
fix half of #125
1 parent 67c24cc commit 18fdd64

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/lib/array.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,9 @@ end
171171

172172
for i = 0:2, c = combinations([:AbstractArray, :TrackedArray, :Number], i), f = [:hcat, :vcat]
173173
cnames = map(_ -> gensym(), c)
174-
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::Union{AbstractArray,Number}...) =
174+
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::AbstractArray...) =
175+
track($f, $(cnames...), x, xs...)
176+
@eval Base.$f($([:($x::$c) for (x, c) in zip(cnames, c)]...), x::Union{TrackedArray,TrackedReal}, xs::Number...) =
175177
track($f, $(cnames...), x, xs...)
176178
end
177179

test/tracker.jl

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,11 @@ end
129129

130130
@testset "scalars" begin
131131
@test vcat(param([1, 2, 3]), 1) isa TrackedArray
132+
@test vcat(param(1), 2) isa TrackedArray
133+
134+
# These two are ambiguity errors on Julia 1.8
132135
@test vcat(1, param([1, 2, 3])) isa TrackedArray
133136
@test hcat(1, param([1 2 3;])) isa TrackedArray
134-
@test vcat(param(1), 2) isa TrackedArray
135137
end
136138

137139
end

0 commit comments

Comments
 (0)