Skip to content

test: fix flaky tests #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

test: fix flaky tests #128

merged 2 commits into from
Jun 11, 2025

Conversation

javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Jun 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated the WebDriverManager library to a newer version for improved compatibility.
  • Tests
    • Increased wait times in UI tests to enhance reliability and reduce flakiness.

@javier-godoy javier-godoy requested review from mlopezFC and paodb June 10, 2025 20:39
Copy link

coderabbitai bot commented Jun 10, 2025

Walkthrough

The pull request updates the webdrivermanager dependency version in the Maven configuration file and refactors the ResponsiveGridIT test class. The test class now uses a centralized helper method to handle sleep intervals, increasing the wait time for asynchronous UI updates.

Changes

Files/Groups Change Summary
pom.xml Updated webdrivermanager dependency version from 3.8.1 to 6.1.0.
src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java Replaced all Thread.sleep(100) calls with a new private sleep() method that sleeps for 500ms and handles InterruptedException.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java (2)

49-50: Repeated fixed sleeps trade flakiness for slowness

sleep() calls now wait 500 ms in eleven places. This unquestionably hides some timing issues but will slow the suite by ~5-6 seconds and may still fail on slower CIs.

Prefer an explicit wait on the real condition (e.g. TestBenchElement#waitUntil, WebDriverWait, or Vaadin’s waitUntil(driver -> grid.hasColumn(...))).
That yields robustness without unnecessary latency.

Also applies to: 56-57, 64-65, 72-73, 80-81, 85-86, 101-102, 115-116, 120-121, 128-129, 173-174


69-70: throws InterruptedException can now be removed

The helper method absorbs the checked exception, so the following test signatures no longer need throws InterruptedException.
Cleaning them up tightens the API and avoids misleading callers.

If you agree, apply (snippet shows one method, replicate for the other two):

-  public void testHideAll() throws InterruptedException {
+  public void testHideAll() {

Also applies to: 111-112, 156-157

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69d29a5 and e93b2ef.

📒 Files selected for processing (2)
  • pom.xml (1 hunks)
  • src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: build-vaadin23
  • GitHub Check: build-vaadin24
🔇 Additional comments (1)
pom.xml (1)

20-20: Version bump looks fine, but watch for profile-specific drift

The root <webdrivermanager.version> is now 6.1.0, yet profile v24 (lines 550-556) still overrides it with 5.6.3.
Running the build with -Pv24 will therefore pull an older binary and may re-introduce the very flakiness you’re trying to fix.

Consider aligning the profile or dropping the override:

-        <webdrivermanager.version>5.6.3</webdrivermanager.version>
+        <webdrivermanager.version>6.1.0</webdrivermanager.version>

or delete the line altogether.

Also check changelog 6.x → 5.x for any breaking changes (e.g. renamed methods, mandatory drivers cache path).

@paodb paodb merged commit ea5ddb5 into master Jun 11, 2025
5 checks passed
@paodb paodb deleted the 20250610 branch June 11, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants