-
Notifications
You must be signed in to change notification settings - Fork 1
test: fix flaky tests #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates the Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java (2)
49-50
: Repeated fixed sleeps trade flakiness for slowness
sleep()
calls now wait 500 ms in eleven places. This unquestionably hides some timing issues but will slow the suite by ~5-6 seconds and may still fail on slower CIs.Prefer an explicit wait on the real condition (e.g.
TestBenchElement#waitUntil
,WebDriverWait
, or Vaadin’swaitUntil(driver -> grid.hasColumn(...))
).
That yields robustness without unnecessary latency.Also applies to: 56-57, 64-65, 72-73, 80-81, 85-86, 101-102, 115-116, 120-121, 128-129, 173-174
69-70
:throws InterruptedException
can now be removedThe helper method absorbs the checked exception, so the following test signatures no longer need
throws InterruptedException
.
Cleaning them up tightens the API and avoids misleading callers.If you agree, apply (snippet shows one method, replicate for the other two):
- public void testHideAll() throws InterruptedException { + public void testHideAll() {Also applies to: 111-112, 156-157
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pom.xml
(1 hunks)src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ResponsiveGridIT.java
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: build-vaadin23
- GitHub Check: build-vaadin24
🔇 Additional comments (1)
pom.xml (1)
20-20
: Version bump looks fine, but watch for profile-specific driftThe root
<webdrivermanager.version>
is now 6.1.0, yet profilev24
(lines 550-556) still overrides it with5.6.3
.
Running the build with-Pv24
will therefore pull an older binary and may re-introduce the very flakiness you’re trying to fix.Consider aligning the profile or dropping the override:
- <webdrivermanager.version>5.6.3</webdrivermanager.version> + <webdrivermanager.version>6.1.0</webdrivermanager.version>or delete the line altogether.
Also check changelog 6.x → 5.x for any breaking changes (e.g. renamed methods, mandatory drivers cache path).
Summary by CodeRabbit