feat: improve how ingress annotations are handled #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stomHostname.ingressAnnotations`
hardillb
reviewed
Oct 7, 2025
| "type": "boolean" | ||
| }, | ||
| "customeHostname": { | ||
| "customHostname": { |
There was a problem hiding this comment.
Wonder how long that's been there
hardillb
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refines how Ingress annotations managed by the FlowFuse Helm chart are handled.
The high-level logic is:
cert-manager.io/cluster-issuer with the value ofingress.certManagerIssuer.1a. Add other non–cert-manager annotations as provided.
2 If
ingress.certManagerIssueris not defined, add all annotations defined iningress.annotations.3 Add the
spec.tlsblock whenever any cert-manager annotation is present, either viaingress.certManagerIssueror defined viaingress.annotations.ingress.certManagerIssuertakes precedence over anycert-manager.io/*annotations specified iningress.annotations.The same logic is applied to the broker Ingress resources.
Additionally, driver configuration values has been extended by
projectIngressAnnotationsandcustomHostname.ingressAnnotationsproperties.Related Issue(s)
#683
FlowFuse/driver-k8s#242
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel