Skip to content

Conversation

@ppawlowski
Copy link
Contributor

Description

This pull requests adds the forge.projectServiceType value which allows to define a service type created for NodeRED deployments. Currently, only ClusterIP (default value from the Kubernetes driver) and NodePort service types are supported.

Related Issue(s)

closes FlowFuse/flowfuse#4041

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@ppawlowski ppawlowski requested a review from hardillb March 2, 2025 19:39
Copy link
Contributor

@hardillb hardillb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs suggestion again.

Also this will need to be done for the mosquitto broker service as well (and look to see if needs applying to emqx)

@ppawlowski
Copy link
Contributor Author

Also this will need to be done for the mosquitto broker service as well (and look to see if needs applying to emqx)

Ok, so maybe I misunderstood the issue - do we want to add a possibility to create all services (core app, brokers, file-service) as NoidePort, instead of ClusterIP?

@ppawlowski ppawlowski requested a review from hardillb March 4, 2025 07:53
Co-authored-by: Ben Hardill <ben@flowforge.com>
@hardillb
Copy link
Contributor

hardillb commented Mar 4, 2025

@ppawlowski any that are pointed to by an ingress route

@ppawlowski ppawlowski marked this pull request as draft March 4, 2025 10:58
@ppawlowski ppawlowski marked this pull request as ready for review March 9, 2025 19:18
@ppawlowski
Copy link
Contributor Author

@ppawlowski any that are pointed to by an ingress route

Handled in separate PR: #547

@hardillb hardillb merged commit f0182ed into main Mar 10, 2025
8 checks passed
@hardillb hardillb deleted the feat-nr-node-port-svc branch March 10, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the option to use NodePort Services on Kubernetes

2 participants