-
Notifications
You must be signed in to change notification settings - Fork 74
Add FF exclusive nodes feature flag #6105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes pushed for the tests. Turns out devices expect Updated tests to check the settings are properly updated depending on the feature flags - more so on the device side. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
+ Coverage 76.81% 76.85% +0.04%
==========================================
Files 380 381 +1
Lines 19230 19272 +42
Branches 4624 4641 +17
==========================================
+ Hits 14771 14812 +41
- Misses 4459 4460 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@knolleary just checking
maps to this in the
|
Actually I don't see anything that would load these default settings from the |
@hardillb I completely overlooked config/settings being separate entities.
Note that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a copy/paste in the error message device
vs project
Co-authored-by: Ben Hardill <ben@flowforge.com>
Closes #6074
Description
Splits the cert-nodes feature flag into two - cert nodes and ff-exclusive nodes.
Updates the UI to simplify the configuration. Admins should only need to provide the registry token
I have renamed the settings we are using as certNodes is now a subset of the full thing. Only impact will be our staging env that'll need the token readding. The settings can be provided via the yaml file under:
platform:ff-npm-registry:url
platform:ff-npm-registry:token
platform:ff-npm-registry:catalogue:certifiedNodes
platform:ff-npm-registry:catalogue:ffNodes
All except for
token
have the right defaults applied (albeit inline in the code rather than the defaults file... ).