Skip to content

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Oct 6, 2025

fixes #6102

Description

This allows for unlimited SSO groups list length rather than limiting to 255 characters

Related Issue(s)

#6102

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

fixes #6102

This allows for unlimited SSO groups list length rather than
limiting to 255 characters
@hardillb hardillb requested a review from knolleary October 6, 2025 12:37
@hardillb hardillb self-assigned this Oct 6, 2025
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.80%. Comparing base (4d412ea) to head (1c75fb2).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
forge/ee/routes/sso/auth.js 0.00% 7 Missing ⚠️
...ge/db/migrations/20251006-01-fix-sso-group-type.js 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6103      +/-   ##
==========================================
- Coverage   76.81%   76.80%   -0.01%     
==========================================
  Files         380      381       +1     
  Lines       19230    19253      +23     
  Branches     4624     4627       +3     
==========================================
+ Hits        14771    14788      +17     
- Misses       4459     4465       +6     
Flag Coverage Δ
backend 76.80% <60.71%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb hardillb changed the title Convert Users.SSOGroups to TEXT from STRING Allow SSO Group lists longer than 255 characters Oct 7, 2025
@hardillb hardillb added the area:migration Involves a database migration label Oct 7, 2025
@hardillb hardillb added this to the 2.23 milestone Oct 7, 2025
@hardillb hardillb moved this to Review in 🛠 Development Oct 7, 2025
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending two minor comment updates to clarify the migration for future reference

@knolleary knolleary self-requested a review October 7, 2025 16:51
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoked my approval as I thought the DB migration filename needed updating - I was wrong. Still approved.

@hardillb hardillb merged commit b8e2af2 into main Oct 8, 2025
22 of 23 checks passed
@hardillb hardillb deleted the sso-group-length branch October 8, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:migration Involves a database migration

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Enabling Expose SSO Groups results in 502 Bad Gateway from NGINX for new login sessions

2 participants