-
Notifications
You must be signed in to change notification settings - Fork 74
Allow SSO Group lists longer than 255 characters #6103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes #6102 This allows for unlimited SSO groups list length rather than limiting to 255 characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6103 +/- ##
==========================================
- Coverage 76.81% 76.80% -0.01%
==========================================
Files 380 381 +1
Lines 19230 19253 +23
Branches 4624 4627 +3
==========================================
+ Hits 14771 14788 +17
- Misses 4459 4465 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending two minor comment updates to clarify the migration for future reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revoked my approval as I thought the DB migration filename needed updating - I was wrong. Still approved.
fixes #6102
Description
This allows for unlimited SSO groups list length rather than limiting to 255 characters
Related Issue(s)
#6102
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label