Home: "Add Instance" button for Hosted & Remote Instances

[joepavitt]

Description

• "Add Instance" button for Hosted Instances
  • Directs to the "Create Instance" page when clicked
  • Add appropriate permissions check to the button too
• "Add Instance" button for Remote Instances
  • Opens "Add Remote Instance" dialog
  • Only shows when permissions are set

Related Issue(s)

Closes #6085

[joepavitt]

@hardillb FYI - assigning you as a reviewer, as I know Serban and nick are locked in RBAC, and Steve on ONNX atm

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.80%. Comparing base (b8e2af2) to head (fe5d524).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6089   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         381      381           
  Lines       19253    19253           
  Branches     4627     4627           
=======================================
  Hits        14788    14788           
  Misses       4465     4465           

Flag	Coverage Δ
backend	76.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hardillb]

@joepavitt re-running backend tests as this is all frontend code so not sure why it's failing

[hardillb]

@joepavitt adding a new device never shows the install instructions, just takes you straight to the device overview page, so no way to get the credentials without clicking on the "finish setup" button or going back to the device list and regenerating them (the finish setup also shows warning about regenerating credentials).

Screencast.From.2025-09-30.14-35-02.mp4

[joepavitt]

Good point, I overlooked that step. Will address it.

[gstout52]

@hardillb Are you able to pick this up?
cc @knolleary

[hardillb]

@gstout52 no, not really

[gstout52]

We'll need to find the right person for it. @knolleary Perhaps @cstns when he is back from OOO?

[knolleary]

@cstns please pick this one up and help get over the line

[cstns]

From what I can tell, this is a two-part problem:

1. We need to redirect to the newly created remote instance.
2. We need to open the remote instance credentials dialog.

The easiest short-term fix would be to only do step two: open the credentials dialog for that specific remote instance without performing a redirect.

The long-term and sustainable fix would be to decouple dialogs from components, similar to how the left/right drawers work. This would allow more complex operations, such as triggering a page redirect followed by a modal. Specifically, we should be able to open a modal from anywhere by passing a data payload and the modal component to load asynchronously. This would remove the need to include each modal in every page where it might be used (and rendered).

I’d estimate the long-term fix at 1 SP, plus 0.25 SP to implement the redirect and credentials modal for the current task, and 0.25 SP to apply the easy fix to meet the immediate requirements.

[cstns]

I replaced the redirect callback after creating a device from the team dashboard with showing the credentials dialog. Let me know If you'd like me to follow up on my previous comment

[hardillb]

@cstns is this ready for review again?

[cstns]

yes, I replaced the redirect to the device page with opening the credentials dialog.

[gstout52]

yes, I replaced the redirect to the device page with opening the credentials dialog.

Thanks @cstns for laying out the options and pursuing the quicker win here.

[hardillb]

@cstns this still isn't doing what I reported to joe when creating a new device.

It still doesn't open the device credentials dialog when creating a new device, it just opens the device's overview page

[hardillb]

@cstns are you sure you pushed changes, the commit history just shows merges of main

[cstns]

it was added in 6fc996e ~5h ago, checking pre-staging once built to confirm

[cstns]

confirming it works on pre-staging

[hardillb]

The commit was not present in the tree when I pulled it to test or when I reviewed it, it just shows the 2 merge main commits