Skip to content

Move to iNKORE.UI.WPF.Modern UI Framework #3593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Conversation

Jack251970
Copy link
Member

@Jack251970 Jack251970 commented May 29, 2025

Use ModernWPF successor iNKORE.UI.WPF.Modern

Resolve #2890.

TODO

This comment has been minimized.

This comment has been minimized.

@prlabeler prlabeler bot added the bug Something isn't working label May 29, 2025
@Jack251970 Jack251970 added the kind/ui related to UI, icons, themes, etc label May 29, 2025
@Jack251970 Jack251970 added this to the Future milestone May 29, 2025

This comment has been minimized.

@Jack251970 Jack251970 linked an issue Jun 2, 2025 that may be closed by this pull request
2 tasks
@Jack251970 Jack251970 mentioned this pull request Jun 2, 2025
1 task
@Jack251970 Jack251970 linked an issue Jun 3, 2025 that may be closed by this pull request
2 tasks
@Jack251970 Jack251970 added enhancement New feature or request and removed bug Something isn't working labels Jun 4, 2025
@prlabeler prlabeler bot added the bug Something isn't working label Jun 5, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings Count
❌ forbidden-pattern 24
⚠️ non-alpha-in-dictionary 13

See ❌ Event descriptions for more information.

Forbidden patterns 🙅 (1)

In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves.

These forbidden patterns matched content:

s.b. workaround(s)

\bwork[- ]arounds?\b
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20 min review bug Something isn't working enhancement New feature or request kind/ui related to UI, icons, themes, etc
Projects
None yet
2 participants