Skip to content

chore: combine packages #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 15, 2025
Merged

chore: combine packages #280

merged 7 commits into from
Jan 15, 2025

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 14, 2025

Prior to this PR, the flagsmith and flagsmith-es packages were separate, this makes the flagsmith sdk both UMD and ES module (mjs).

This release will log a deprecated notice to flagsmith-es preinstall, following this release there will be no more versions of Flagsmith-es.

Requires merging #281 first

Testing

  • Test sourcemaps still work
  • Test UMD example e.g. a simple react application
  • Install flagsmith using an esm based framework e.g. svelte
  • Install react-native-flagsmith

@kyle-ssg kyle-ssg requested a review from tiagoapolo January 15, 2025 10:16
Copy link
Contributor

@tiagoapolo tiagoapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

# Conflicts:
#	lib/flagsmith-es/package-lock.json
#	lib/flagsmith-es/package.json
#	lib/flagsmith/package.json
#	lib/react-native-flagsmith/package.json
@kyle-ssg kyle-ssg merged commit 4afc3bf into main Jan 15, 2025
1 check passed
@kyle-ssg kyle-ssg deleted the chore/combine-packages branch January 15, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle ES(flagsmith-es) and combine with standard CJS module (flagsmith)
2 participants