Skip to content

fix: Unhandled exception when getting value from local storage #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 10, 2025

Based on sentry's log when AsyncStorage.setItem fails, the code is not handling that exception.

Reference: #278

@tiagoapolo tiagoapolo self-assigned this Jan 10, 2025
@tiagoapolo tiagoapolo force-pushed the fix/278--get-value-unhandled-exception branch from 2d48935 to 43bd3c5 Compare January 10, 2025 13:22
@tiagoapolo tiagoapolo added the bug Something isn't working label Jan 10, 2025
Copy link
Member

@rolodato rolodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual fix LGTM, left some minor comments/suggestions that I don't yet know the answer to :)

@tiagoapolo tiagoapolo merged commit 84c1618 into main Jan 13, 2025
1 check passed
@tiagoapolo tiagoapolo deleted the fix/278--get-value-unhandled-exception branch January 13, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants