Skip to content

Get the modification time of a config file with a higher precision to fix cases when it's not reloaded after modification/replacement #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ilya071294
Copy link
Contributor

The fix is needed to avoid potential problems in Firebird QA.

… fix cases when it's not reloaded after modification/replacement

The fix is needed to avoid potential problems in Firebird QA.
@aafemt
Copy link
Contributor

aafemt commented May 5, 2025

Wouldn't it be better to make Windows version of getTime to return timespec and unify the rest of code?

Also it is simpler to use GetFileAttributesEx than FindFirstFile.

@ilya071294
Copy link
Contributor Author

Wouldn't it be better to make Windows version of getTime to return timespec and unify the rest of code?

I can do that if conversion to timespec on every checkLoadConfig call is appropriate. @AlexPeshkoff What do you think?

Also it is simpler to use GetFileAttributesEx than FindFirstFile.

Done.

@aafemt
Copy link
Contributor

aafemt commented May 6, 2025

I can do that if conversion to timespec on every checkLoadConfig call is appropriate.

IIRC this "conversion" is a couple of multiplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants