fix: FLUI-146 fix date test and typo #565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
0 tests passing in 0 suite.
Report generated by 🧪jest coverage report action from 4290432
Project Coverage and TestStatements : 34.29% ( 10633/31005 ) Test Suites: 58 passed, 58 total |
emmanuelnau
reviewed
Jan 7, 2025
| const startYear = new Date(today.getFullYear(), 0, 1); | ||
| const endPeriodTime = new Date(today.getFullYear(), today.getMonth(), today.getDate() - 2); | ||
|
|
||
| const randomDate = new Date( |
There was a problem hiding this comment.
Pourquoi avoir une date random et non fixe ?
Il me semble qu'il est préférable d'avoir des tests prédictibles pour les tests.
emmanuelnau
reviewed
Jan 7, 2025
| expect(getRelativeDate(yesterday, format)).toEqual('yesteday'); | ||
| expect(getRelativeDate(yesterday, format)).toEqual('yesterday'); | ||
| }); | ||
| test('should return this years date', () => { |
There was a problem hiding this comment.
should return this year date non ?
emmanuelnau
approved these changes
Jan 7, 2025
claudia1296
force-pushed
the
fix/flui-146
branch
from
4290432 to
3f9d040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix date test and typo
Description
Acceptance Criterias
Links
Extra Validation
Screenshot or Video
Before
After
QA
Steps to validate
Mention