New feature: REPLACE_PERSISTENT_COLLECTIONS to fix #93

[NagyGa1]

(to fix #93)

With typing enabled, Hibernate PersistentCollections cannot be deserialized. The feature replaces them during serialization.

[digulla]

Suggestion: Instead of having a comment in the unit tests, test for the presence of the bug #94

That way, the test will naturally fail when #94 is fixed and the comment will let you know how to fix it.

I'd also suggest to move the setup and teardown code into @before and @after methods; since JUnit 4, instances of test classes aren't kept in memory anymore (JUnit 4 only keeps test results). That would make the test much easier to read and it would follow the DRY principle.

[NagyGa1]

Updated pull request.

BaseTest extends JUnit3's junit.framework.TestCase, which is no longer necessary, might send a pull request for that tomorrow.

[cowtowncoder]

@NagyGa1 Sounds like a good feature, thank you for implementing and contributing this!

Before merging this in, one formality we need is the Contributor License Agreement (CLA), unless we have received one earlier. It's a one-page document found here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and usually it's printed, filled & signed, scanned and email to info at fasterxml.com

Looking forrward to merging this.

[cowtowncoder]

Ok: usually this would only go in the next minor release, but since we do not yet have master moved to 2.9, I will merge so that it will be part of 2.8.2 and later 2.8.x. It will be "hidden" feature as javadocs will remain at 2.8.0, but technically it can be used.

[NagyGa1]

Excellent, thank you very much.

On 31 July 2016 at 02:33, Tatu Saloranta notifications@github.com wrote:

Merged #95
#95.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#95 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AG9fcmc9mb-O8T0dWHZA2Bk1FY1iGeHHks5qa5j6gaJpZM4JTg73
.