feat(#4218): avoid executing the injection logic multiple times #5201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Context to avoid executing the injection logic multiple times
JooHyukKim
reviewed
Jun 24, 2025
Comment on lines
+495
to
+507
|
|
||
| Object value = _injectablesCache.get(valueId); | ||
|
|
||
| if (value == null) { | ||
| value = _injectableValues.findInjectableValue(this, valueId, forProperty, beanInstance, | ||
| optional); | ||
|
|
||
| if (value != null) { | ||
| _injectablesCache.put(valueId, value); | ||
| } | ||
| } | ||
|
|
||
| return value; |
There was a problem hiding this comment.
Would this make injectino logic to run exactly once? Or less than before
There was a problem hiding this comment.
Exactly once, as proven by this test, which doesn't fail anymore with the change above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given there are multiple entry points for injection (creator properties vs fields and setters), would a cache in
DeserializationContextbe good to avoid executing the injection logic multiple times? Is the tradeoff of having a bit more space consumption vs much lower (I guess) execution time performance worth it?Especially considering that every new feature added in the
@JacksonInjectcontext, without a cache would mean duplicating the logic in a slightly different way, since creator properties and fields injection are managed differently.