Replace deprecated via.placeholder.com with placehold.co #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the default image placeholder URL in the Image provider from https://via.placeholder.com (which is no longer available) to https://placehold.co. This change ensures that Faker's imageUrl() method returns valid, working placeholder image URLs. It fixes broken image links and maintains compatibility for users relying on Faker-generated images.
|
Failed tests |
Oh no, I replaced https://via.placeholder.com/ with https://placehold.co/ and didn’t write a full test suite, integration plan, and ISO certification report. Truly reckless. I’ll get started on building an entire QA department just to verify this image URL switch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the reason for this PR?
Updated the default image placeholder URL in the Image provider from https://via.placeholder.com (which is no longer available) to https://placehold.co. This change ensures that Faker's imageUrl() method returns valid, working placeholder image URLs. It fixes broken image links and maintains compatibility for users relying on Faker-generated images.