Skip to content

[TTT] Added Attacker and Inflictor to usages of SWEP:FireBullets #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Malivil
Copy link
Contributor

@Malivil Malivil commented May 4, 2025

No description provided.

@mgetJane
Copy link
Contributor

mgetJane commented May 4, 2025

have you tested this? ttt and probably a lot of older addons expect inflictor == attacker for gunshot damage

@Malivil
Copy link
Contributor Author

Malivil commented May 4, 2025

have you tested this? ttt and probably a lot of older addons expect inflictor == attacker for gunshot damage

I tested it locally with bots and a modified version of your death panel addon and it seemed fine. I didn't do anything super extensive. Are there scenarios you'd like me to test specifically?

@robotboy655 robotboy655 added TTT The pull request is for TTT and will be handled by svdm. Enhancement The pull request enhances current functionality. labels May 4, 2025
@Malivil
Copy link
Contributor Author

Malivil commented May 4, 2025

I ran a test with about 100 weapons from different packs and bases (Lykrast's, WWII Collection, M9k, Overwatch weapons [TFA Base]) and they are all functioning and going through to the attacker and dmginfo:GetInflictor() in DoPlayerDeath correctly as far as I can tell.

@Malivil
Copy link
Contributor Author

Malivil commented May 5, 2025

image
I'll test the events screen and the clientside hitreg mod a little later to be sure

@Malivil
Copy link
Contributor Author

Malivil commented May 5, 2025

Ran a test on a dedicated server with clientside hitreg and everything still seems fine. Event logs show the correct weapons, shots are registered and attributed correctly as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality. TTT The pull request is for TTT and will be handled by svdm.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants