Skip to content

Add player.GetByNick #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add player.GetByNick #2283

wants to merge 1 commit into from

Conversation

Astralcircle
Copy link
Contributor

It will be a convenient addition for different admin mods so that, for example, when entering commands, you don’t have to write your own detection logic by nick

@Astralcircle
Add player.GetByNick
c887234 
It will be a convenient addition for different admin mods so that, for example, when entering commands, you don’t have to write your own detection logic by nick
@bloodycop6385
Copy link
Contributor

why not use player.Iterator()?

@Astralcircle
Copy link
Contributor Author

Astralcircle commented May 3, 2025 •
edited
Loading

why not use player.Iterator()?

Because other player.GetBy* functions don't use it either and I don't know exactly how it can affect stability. If Rubat tells me to use player.Iterator as in my previous PR for optimizing the team library, I will do it.

@robotboy655 robotboy655 added the Addition The pull request adds new functionality. label May 9, 2025
@Astralcircle Astralcircle deleted the getbyname branch May 25, 2025 23:05
@Astralcircle Astralcircle restored the getbyname branch May 26, 2025 15:21
@Astralcircle
Copy link
Contributor Author

Woops, accidentally deleted the branch

@Astralcircle Astralcircle reopened this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Addition The pull request adds new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astralcircle @bloodycop6385 @robotboy655