Improving the problems menu

[darkfated]

• Combined duplicate problem and error list refresh functions into a single shared RefreshList function to improve code maintainability and reduce code duplication
• The changes improve sorting performance in ReceivedError() function by implementing a single-pass array sorting with numeric indices instead of multiple iterations. This optimization reduces memory allocations and improves efficiency when handling large numbers of error panels
• Added menu closing functionality using the ESCAPE key. (Implementation uses input.IsKeyDown() in the Think() method since the standard OnKeyCodePressed handler doesn't capture the ESCAPE key in Garry's Mod menu system). This improves UX by allowing users to close the menu using the standard game key

[darkfated]

Let me briefly explain my optimization 🙃

Both algorithms (the existing one and mine) have the same O(n log n) complexity, but my version has fewer operations and a better constant factor. At low error counts, the difference is negligible, but at scale, mine will be faster. I also use an array instead of a hash table, which is more efficient, and perform fewer sorting passes

[robotboy655]

Please actually test your changes before making a Pull Request. How many times do I have to encounter PRs that do not work?

[darkfated]

I made the problem menu close on ESP only in the main menu. I also rolled back the changes related to the list refresh processing function. The mistake was that I carelessly passed the table that I made a copy of in the argument and cleaned it up locally. I decided to return the old version

[darkfated]

I would suggest the idea of closing the menu also by clicking in a free area of the screen

[darkfated]

cls_background.mp4

[robotboy655]

You should not be removing the default close button.

[darkfated]

You should not be removing the default close button.

All done