Add "Assert" Global Function #2206
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom assert with more features, such as allowing to provide a level the error is thrown at, whether or not the error should halt, and the varargs are used to format the error message.
So that it returns the correct error level on successful assertion
So that, on successful assertion, it returns the error message properly formatted
There really isn't a need to return errorLevel and noHalt
|
Seems like a nice addition, but it might belong better in a 3rd party library imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A custom assert function that has more features. Unlike the default
assertfunction, this function allows you to provide a level to which the error is thrown at. It also has anoHaltargument to make the error not halt the code. The varargs are now used to format the error message.Allowing to provide an error level will allow us to make it actually point to the faulting file, whereas the default
assertonly throws the error at stack level 1, making it seem like we caused the error.For those with cases that need the error to not halt, or need to format the error message, this function has it built in for convenience, keeping it looking nice and clean.
On a successful assertion, it returns the expression value, the (formatted) error message, and all of the varargs.