Novgui voice chat support #491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er head sprite creation.
…her the player is speaking or not
…ws you to display the speaker icon on the novgui scoreboard. (At the moment, the view in novgui scoreboard is not completed)
nekonomicon
requested review from
FreeSlave,
SNMetamorph,
Velaron,
Vladislav4KZ,
a1batross and
mittorn
|
That's good idea. But I think implementation is somehow bloated. Maybe it's possible to implement such thing without modifying VGUI-related code, and consequently many of that |
|
Some files changed are just unnecessary formatting, like voice_status.cpp/h, try reverting those |
|
Also there is a lot of copy-pasted code, I think it's possible to merge both files and put the modified lines under macros? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the voice chat interface without vgui and the display of the icon in the novgui scoreboard (it is not completed because I am lazy), if necessary, you can finish and redo it as needed