Skip to content

Conversation

@FreeSlave
Copy link
Member

After switching to Ninja the vgui autobuild is broken because ninja uses a different current directory.
I kept copying vgui.so to the cl_dll/ intact just in case someone changes generator back to Makefiles.

@a1batross
Copy link
Member

I think it's only required for steamrt build because the issue with vgui.so is being linked by full path is an ancient binutils bug.

@FreeSlave
Copy link
Member Author

Maybe. But github actions are currently using steamrt.
This allows to build libraries that are surely compatible with GoldSource on Linux.
As far as I remember I was having problems with some gcc/g++ versions producing incompatible binaries.

@a1batross
Copy link
Member

Wait, everything uses steamrt? I thought manual.yml just uses whatever is on CI machine.

@FreeSlave
Copy link
Member Author

Can we merge it? Users are complaining already! :)

@a1batross a1batross merged commit 852fc5a into FWGS:master Nov 3, 2024
4 checks passed
@FreeSlave FreeSlave deleted the fix-vgui-autobuild branch November 3, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants