Update mass and moment of inertia constants for improved speed #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the robot's physical constants for improved performance accuracy.
- The MASS constant was updated from 20 kilograms to 15 kilograms.
- The MOI constant was updated from 8.0 to 6.8.
Comments suppressed due to low confidence (1)
src/main/java/frc/robot/Constants.java:245
- The TODO comment contains spelling errors: 'Calcuate' should be 'Calculate' and 'vaule' should be 'value'.
// TODO: Calcuate the real vaule
TaylerUva
added
the
✨ Code Good - Ready to Test
…into 391-4-piece-auto
Closed
4 tasks
auto-merge was automatically disabled
April 9, 2025 04:01
Pull request was converted to draft
…into 391-4-piece-auto
TaylerUva
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
AUTOclass in theConstants.javafile to adjust the mass and moment of inertia (MOI) values. These changes are likely made to reflect more accurate or updated measurements for the robot's physical properties.Key changes include:
src/main/java/frc/robot/Constants.java: Updated theMASSvalue from 20 kilograms to 15 kilograms.src/main/java/frc/robot/Constants.java: Updated theMOIvalue from 8.0 to 6.8.