Auto fixes (￣o￣) . z Z #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the autonomous mode initialization by moving odometry reset logic from individual auto command sequences into a centralized onChange callback on the auto chooser. Additionally, it adjusts rotation inversion behavior for simulation environments and adds missing .asProxy() calls.
- Centralizes odometry reset using
autoChooser.onChange()callback instead of embedding it in each auto sequence - Removes default option status from "4 Coral - Processor Side" autonomous mode
- Conditionally inverts rotation based on simulation state
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RobotContainer.java | Adds centralized odometry reset via onChange callback, removes redundant resetOdometry calls from auto sequences, changes default auto option, and adds missing asProxy() call |
| Constants.java | Makes rotation inversion conditional based on simulation state |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-Authored-By: Yutong Zhu <3681247216@qq.com>
Co-Authored-By: Yutong Zhu <3681247216@qq.com>
Co-Authored-By: Yutong Zhu <3681247216@qq.com>
TaylerUva
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.