Skip to content

Remove rdf4j-generator-maven-plugin dependency #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Remove rdf4j-generator-maven-plugin dependency #719

merged 2 commits into from
Jun 10, 2025

Conversation

dennisvang
Copy link
Contributor

@dennisvang dennisvang commented Jun 5, 2025 •
edited
Loading

  • removed the rdf4j-generator-maven-plugin dependency (project is archived and possibly causing Sudden failures in Github actions #714 )
  • added previously generated vocabulary classes to the main code base
  • removed unused vocabulary terms and refactored classes for consistency

fixes #612
fixes #714
fixes #716

PatrickDekkerHealthRI and others added 2 commits June 5, 2025 21:24
@PatrickDekkerHealthRI @dennisvang
cherry-pick fix: remove rdf4j-generator (#715)
8d6b1b1 
* fix: remove rdf4j-generator

* fix: checkstyle warnings on DATACITE,FDP, R3D generate classes and remove SCHEMAORG
@dennisvang
cherry-pick: Clean up vocabulary classes (#717)
f265192 
* remove unused WebAccessControl vocabulary

* rename vocabulary.Sio to SIO and use util.ValueFactoryHelper.i for consistency

* remove unused terms from DATACITE vocabulary and refactor for consistency

* remove unused terms from R3D vocabulary and refactor for consistency

* remove unused terms from FDP vocabulary and refactor for consistency
@dennisvang dennisvang requested a review from MarekSuchanek June 5, 2025 20:05
MarekSuchanek
MarekSuchanek approved these changes Jun 8, 2025
View reviewed changes
Copy link
Contributor

@MarekSuchanek MarekSuchanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally agree with this, the generator also caused extra dependencies on external resources during compile time and it was resulting in issues here and there... 👏🏻

@dennisvang dennisvang merged commit 6a1de45 into develop Jun 10, 2025
13 checks passed
@dennisvang
Copy link
Contributor Author

Thanks for the review @MarekSuchanek :)

@dennisvang dennisvang deleted the fix/issue612 branch June 10, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekSuchanek MarekSuchanek MarekSuchanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up vocabulary Sudden failures in Github actions archived rdf4j-generator-maven-plugin dependency
3 participants
@dennisvang @MarekSuchanek @PatrickDekkerHealthRI