fix: remove rdf4j-generator #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @PatrickDekkerHealthRI that looks good. I wonder if we can remove the unused classes and terms. |
dennisvang
approved these changes
Jun 5, 2025
dennisvang
merged commit 0230bae
into
FAIRDataTeam:support/1.17.x
11 of 13 checks passed
Closed
dennisvang
pushed a commit
that referenced
this pull request
Jun 5, 2025
* fix: remove rdf4j-generator * fix: checkstyle warnings on DATACITE,FDP, R3D generate classes and remove SCHEMAORG
dennisvang
added a commit
that referenced
this pull request
Jun 10, 2025
* cherry-pick fix: remove rdf4j-generator (#715) * fix: remove rdf4j-generator * fix: checkstyle warnings on DATACITE,FDP, R3D generate classes and remove SCHEMAORG * cherry-pick: Clean up vocabulary classes (#717) * remove unused WebAccessControl vocabulary * rename vocabulary.Sio to SIO and use util.ValueFactoryHelper.i for consistency * remove unused terms from DATACITE vocabulary and refactor for consistency * remove unused terms from R3D vocabulary and refactor for consistency * remove unused terms from FDP vocabulary and refactor for consistency --------- Co-authored-by: Patrick Dekker <168626347+PatrickDekkerHealthRI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the dependency on (archived) rdf4j-generator, by removing the plugin from the maven pom.file.
And moved the generated source files to the normal source files.
this fixes #612 and fixes #714 (workaround)